-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove symlinking of encore.dev package #1662
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All committers have signed the CLA. |
eandre
force-pushed
the
remove-symlink
branch
from
December 19, 2024 15:22
b4bedc4
to
9c990a2
Compare
eandre
force-pushed
the
remove-symlink
branch
from
December 19, 2024 23:35
9c990a2
to
34bad99
Compare
eandre
force-pushed
the
remove-symlink
branch
6 times, most recently
from
December 27, 2024 09:12
d25b237
to
d2518cc
Compare
eandre
force-pushed
the
remove-symlink
branch
5 times, most recently
from
January 9, 2025 10:34
8c06a94
to
e0f7f92
Compare
fredr
reviewed
Jan 9, 2025
fredr
reviewed
Jan 9, 2025
fredr
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the symlinking behavior of
encore.dev
, opting instead to manage the version number inpackage.json
to ensure versions stay consistent between the daemon and theencore.dev
sdk.