Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove symlinking of encore.dev package #1662

Merged
merged 13 commits into from
Jan 9, 2025
Merged

Conversation

eandre
Copy link
Member

@eandre eandre commented Dec 19, 2024

This removes the symlinking behavior of encore.dev, opting instead to manage the version number in package.json to ensure versions stay consistent between the daemon and the encore.dev sdk.

@encore-cla
Copy link

encore-cla bot commented Dec 19, 2024

All committers have signed the CLA.

@eandre eandre marked this pull request as draft December 19, 2024 15:23
@eandre eandre marked this pull request as ready for review December 19, 2024 23:40
@eandre eandre force-pushed the remove-symlink branch 6 times, most recently from d25b237 to d2518cc Compare December 27, 2024 09:12
@eandre eandre force-pushed the remove-symlink branch 5 times, most recently from 8c06a94 to e0f7f92 Compare January 9, 2025 10:34
@eandre eandre requested a review from fredr January 9, 2025 10:45
Copy link
Member

@fredr fredr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚢

@eandre eandre merged commit b8f95e2 into encoredev:main Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants